Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toJavaProto/fromJavaProto is incomplete for FieldOptions on UnknownFieldSet #934

Open
mantasindrasius opened this issue Oct 5, 2020 · 3 comments

Comments

@mantasindrasius
Copy link

mantasindrasius commented Oct 5, 2020

Conversions from java protobuf library to scala and back are missing the

Misses UnknownFieldSet in one of the fields:

FileDescriptorProto.fromJavaProto(javaFileDescriptorProto)

This works:

FileDescriptorProto.parseFrom(javaFileDescriptorProto.toByteArray)

The methods seems lacking the UnknownFieldSet setters:
https://github.com/scalapb/ScalaPB/blob/master/scalapb-runtime/src/main/scalajvm/com/google/protobuf/descriptor/FieldOptions.scala#L211

@thesamet
Copy link
Contributor

thesamet commented Oct 5, 2020

@mantasindrasius , thanks for reporting! I confirm that unknown fields are not converted to/from java for any ScalaPB message. Will you be able to work on a PR for this?

@mantasindrasius
Copy link
Author

Not sure at the moment, but I'll notify in case I'll be able to.

@thesamet
Copy link
Contributor

thesamet commented Oct 6, 2020

@mantasindrasius That's ok. For context, does this issue has practical implications on your project or is it just a gap that you've identified?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants