Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

controllers for functionality #874

Open
ameet20 opened this issue Jan 23, 2019 · 1 comment
Open

controllers for functionality #874

ameet20 opened this issue Jan 23, 2019 · 1 comment
Labels

Comments

@ameet20
Copy link

ameet20 commented Jan 23, 2019

In particular, use of multiple ScalatraFilters makes deep stack. It would be nice if we can composite them to a single controller and they are proceeded by loop rather than nested filters chain

@takezoe
Copy link
Member

takezoe commented Jan 23, 2019

Good point! Just from that reason, we use a filter which allows to composite multiple ScalatraFilters in GitBucket which is an open source git server based on Scalatra:
https://github.com/gitbucket/gitbucket/blob/master/src/main/scala/gitbucket/core/servlet/CompositeScalatraFilter.scala

But I'm not sure if this filter should be a part of Scalatra itself.

@takezoe takezoe added the core label Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants