Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabasePublisherTckTest flaky if MySQL #2098

Open
xuwei-k opened this issue Nov 18, 2023 · 2 comments
Open

DatabasePublisherTckTest flaky if MySQL #2098

xuwei-k opened this issue Nov 18, 2023 · 2 comments

Comments

@xuwei-k
Copy link
Member

xuwei-k commented Nov 18, 2023

@yoskhdia
Copy link
Member

yoskhdia commented Dec 6, 2023

Are the following errors a problem?

[info] DatabasePublisherTckTest:
[info] - optional_spec104_mustSignalOnErrorWhenFails *** FAILED ***
[info]   java.lang.RuntimeException: Publisher threw exception (Error-state Publisher scalikejdbc.streams.DatabasePublisher@5203e155 did not call `onError` on new Subscriber within 150 ms) instead of signalling error via onError!

The timeout is currently 150 milliseconds, and indeed this value may be flaky for some DBs.

Originally, TCK had a default value of 100 milliseconds, which was increased to 150 milliseconds due to unstable testing.
Therefore, increasing this timeout value slightly is one possible solution. What do you think?

@seratch
Copy link
Member

seratch commented Dec 29, 2023

If adjusting the duration works, I believe it's worth trying. Can you send a PR for it?

@seratch seratch added this to the version 4.2.x milestone Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants