Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] If pairing is successful but connection fails Edit Paired Devices dialog shows undefined #221

Open
schlagmichdoch opened this issue Dec 13, 2023 · 2 comments · May be fixed by #267
Assignees
Labels
enhancement New feature or request under development

Comments

@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Dec 13, 2023

This is due to the signaling server working as expected but the WebRTC connection failing. As the (edited) deviceNames are transferred between the devices only without ever being sent to the server, the Edit Dialog shows "undefined" as long as there hasn't been a successful WebRTC connection.

Probably, we should prefill the IndexedDB with the generated device names though. I'll create a separate issue for that.

Originally posted by @schlagmichdoch in #215 (comment)

To include edited device names, the IndexedDB entries for device and display name are only added after there was a successful WebRTC connection between the two devices. The reduce confusion we should prefill the IndexedDB entries with the server generated random names.

@schlagmichdoch schlagmichdoch changed the title [Enhancement] If pairing is successfull but connection fails Edit Dialog shows undefined [Enhancement] If pairing is successful but connection fails Edit Paired Devices dialog shows undefined Dec 13, 2023
@schlagmichdoch schlagmichdoch added the enhancement New feature or request label Dec 13, 2023
@francuss
Copy link

It is happening to me too, Pairdrop works on Linux and Android, but for transferring a file to Safari Mac, it pairs but the transfer fails just when it begins.

I tried to install Brave Browser on Mac, but the result is the same.

If there is a solution I did not understand what it is

@schlagmichdoch
Copy link
Owner Author

It is happening to me too, Pairdrop works on Linux and Android, but for transferring a file to Safari Mac, it pairs but the transfer fails just when it begins.

I tried to install Brave Browser on Mac, but the result is the same.

If there is a solution I did not understand what it is

Sorry for the late reply, somehow I have missed your comment.

I’m not sure what the problem is, but I believe it is unrelated to this issue. Is the device gone completely after the transfer fails? Then it is probably connected to this issue: #260

schlagmichdoch added a commit that referenced this issue Feb 6, 2024
…t displayName `undefined` in EditPairedDevices Dialog (fixes #221)
@schlagmichdoch schlagmichdoch linked a pull request Feb 9, 2024 that will close this issue
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request under development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants