Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Make AddOn Snapdrop for Firefox compatible with PairDrop #232

Open
ueen opened this issue Dec 23, 2023 · 4 comments
Open

[Enhancement] Make AddOn Snapdrop for Firefox compatible with PairDrop #232

ueen opened this issue Dec 23, 2023 · 4 comments
Labels
browser-extension enhancement New feature or request

Comments

@ueen
Copy link

ueen commented Dec 23, 2023

Hey, I'd like to update my snapdrop webaddon to default to pairdrop bc snapdrop is just to unreliable and pairdrop has made great strides in UI/UX but it also got quite complicated.

Question just is, how would you like it to work, i once envisioned to have it run in background so recieving is always possible, but that might be overkill? (also would require to incorperate your code in the adddon - LICENSE?)

What i would like to do is add the current tab url automatically in th text field, how may i do that?

Everything else should be pretty straight forward :)

here is the current version
https://github.com/ueen/SnapdropFirefoxAddon/tree/main

I realized this should've been a discussion, but i'm not familiar with them yet, sorry

@ueen ueen added the enhancement New feature or request label Dec 23, 2023
@ueen ueen changed the title [Enhancement] Webextebnsion [Enhancement] Webextension Dec 23, 2023
@schlagmichdoch schlagmichdoch changed the title [Enhancement] Webextension [Enhancement] Make AddOn Snapdrop for Firefox compatible with PairDrop Jan 6, 2024
@ueen
Copy link
Author

ueen commented Jan 6, 2024

Thank you very much, I would do a new add-on called Pairdrop Webextension and deprecate the existing one or rather let I work but not update.

Here it is, new and shiny: PairdropWebExtension

Thank you for the Info's, I'll check main.is and hope I can ask back here if I'm stuck?

not sure when I'll find time to work on this. the basic thing should only take 1-2 hours, but background service is kinda complicated and I think doesn't even work right now for Snapdrop - so that would take some dedicated work.

@ueen
Copy link
Author

ueen commented Jan 9, 2024

do you have a updated logo that i could use in the addon? :)

alpha soon available here
https://addons.mozilla.org/de/firefox/addon/pairdrop-web-extension/

@schlagmichdoch
Copy link
Owner

Thank you for the Info's, I'll check main.is and hope I can ask back here if I'm stuck?

Sure thing, ask whenever you need help. The main.js is the starting point for the code, but if you just want to show a running version, you can point to index.html as before and everything should run.

do you have a updated logo that i could use in the addon? :)

You can use the main blue logo in the public/images folder if it will be cropped by the store or use the cropped version

Repository owner deleted a comment from schlagmichdoch Feb 17, 2024
@schlagmichdoch
Copy link
Owner

The following comments were deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The correct thread order and the creation date is unclear. I decided to manually restore them anyway in order to complete the information this issue holds even though the restored information might be outdated:

Comment by @schlagmichdoch:

Hey, I'd like to update my snapdrop webaddon to default to pairdrop bc snapdrop is just to unreliable and pairdrop has made great strides in UI/UX but it also got quite complicated.

Sounds good. This would require renaming the extension or adding labels to the entry in the Firefox AddOn Store so users are able to find it.

Question just is, how would you like it to work, i once envisioned to have it run in background so recieving is always possible, but that might be overkill?

Why would that be overkill? I think that's one of the main features the extension could fullfill:

  1. Running in background to be able to receive always
  2. Quickly sending the current URL
  3. Quickly sending a file/message

also would require to incorperate your code in the adddon - LICENSE?)

It's the same License as the License of Snapdrop (that's needed).

Also, with this license you can use the code however you want as long as everything stays FOSS (free opensource software).

See the license itself and this explanation on another issue: #23 (comment)

What i would like to do is add the current tab url automatically in th text field, how may i do that?

I would not do that. Rather, I would add a shortcut / context menu entry / button to send the URL via the Share Target API that uses PairDrops share mode. It's enough to add it as a URL argument:
https://pairdrop.net?share_target=text&url=https://google.com/

but it also got quite complicated

What do you mean? The biggest change is probably that everything is modularized. Apart from that you still find everything you need client wise here: https://github.com/schlagmichdoch/PairDrop/tree/master/public

With main.js as entry point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-extension enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants