Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] Add environment variable to set manifest variable "display": "standalone" #264

Open
schlagmichdoch opened this issue Feb 5, 2024 · 0 comments · May be fixed by #267
Open

[enhancement] Add environment variable to set manifest variable "display": "standalone" #264

schlagmichdoch opened this issue Feb 5, 2024 · 0 comments · May be fixed by #267
Labels
enhancement New feature or request

Comments

@schlagmichdoch
Copy link
Owner

schlagmichdoch commented Feb 5, 2024 •
edited

As discussed in #254 there should be a possibility for admins to set the display mode.

As iOS cannot use PWAs in share menus and QR codes are always opening in the browser, the current default is 'display': 'minimal-ui'.

Maybe set 'display': 'standalone' as default anyway, as it would be an enhancement for UI clarity (hides the address bar).
@schlagmichdoch schlagmichdoch changed the title Make the manifest variable "display": "standalone" editable via an environment variable and stand Add environment variable to set manifest variable "display": "standalone" Feb 5, 2024
@schlagmichdoch schlagmichdoch added enhancement New feature or request to be decided labels Feb 5, 2024
@schlagmichdoch schlagmichdoch changed the title Add environment variable to set manifest variable "display": "standalone" [enhancement] Add environment variable to set manifest variable "display": "standalone" Feb 5, 2024
@schlagmichdoch schlagmichdoch linked a pull request Feb 17, 2024 that will close this issue
Open
42 tasks
schlagmichdoch added a commit that referenced this issue May 16, 2024
@schlagmichdoch
Make PWA run standalone (fixes #264)
8a56a27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: Release Next Major Version v2.0.0 schlagmichdoch/PairDrop
1 participant
@schlagmichdoch