Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] If using client mode, do not send peers from another ws-domain #269

Open
schlagmichdoch opened this issue Feb 13, 2024 · 0 comments · May be fixed by #267
Open

[Enhancement] If using client mode, do not send peers from another ws-domain #269

schlagmichdoch opened this issue Feb 13, 2024 · 0 comments · May be fixed by #267
Labels
bug Something isn't working security

Comments

@schlagmichdoch
Copy link
Owner

Describe the bug
Currently, peer secrets are saved in one database without specifying the websocket domain they are used with. This is not a problem for normal operation, as the IndexedDB databases are specific to each domain.

Expected behavior
To prevent sending secrets not created by the websockets specified via the client mode, we should add an entry ws-domain to the table and save the currently used websocket domain to it. Then, when connecting to a websocket, only those peer secrets belonging to the ws-domain or rather always only get those room secrets that belong to the websocket domain via the PersistentStorage class.

@schlagmichdoch schlagmichdoch added bug Something isn't working security labels Feb 13, 2024
@schlagmichdoch schlagmichdoch linked a pull request Feb 14, 2024 that will close this issue
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant