Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Switching public rooms does not disconnect from devices in old public room #298

Open
schlagmichdoch opened this issue Apr 30, 2024 · 0 comments
Labels
bug Something isn't working security

Comments

@schlagmichdoch
Copy link
Owner

This issue was deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The creation date is unclear. There are also links to the deleted issue that are not updated to this issue. I decided to manually recreate it anyway in order to complete the information the repo holds even though the restored information might be outdated:

Issue by @schlagmichdoch:

Describe the bug
When joining a public room (N) while already in a public room (O), room N is joined but room O is not left. When room N is then left actively, room O is still present and can not be left by the user.

To Reproduce
Steps to reproduce the behavior:

  1. Enter a public room (O)
  2. Connect to a peer in this room (by entering the same room (O) on another device)
  3. Enter a second public room (N)
  4. --> Still see devices in room O
  5. Leave room N
  6. --> Still see devices in room O

Expected behavior
When peer joins a new room server removes it from all old public rooms.

Bug occurs on official PairDrop instance https://pairdrop.net/
Yes
Version: v1.10.7

Bug occurs on self-hosted PairDrop instance
Yes

@schlagmichdoch schlagmichdoch added bug Something isn't working security labels Apr 30, 2024
@schlagmichdoch schlagmichdoch changed the title [Bug] Switching public rooms does not leave old public room [Bug] Switching public rooms does not disconnect from devices in old public room May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working security
Projects
None yet
Development

No branches or pull requests

1 participant