Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Button Proptypes linting issue/ Global Props #143

Open
1 task
summer-cook opened this issue Jan 31, 2023 · 1 comment
Open
1 task

Fix Button Proptypes linting issue/ Global Props #143

summer-cook opened this issue Jan 31, 2023 · 1 comment

Comments

@summer-cook
Copy link
Contributor

summer-cook commented Jan 31, 2023

story

buttonprops are being brought in to the linked button, which is causing this linting warning

Image

it would be helpful to have buttonprops and maybe image props in a global props file that we could import these from.

resources

https://stackoverflow.com/questions/58482573/react-inherit-copy-proptypes-from-another-component
https://stackoverflow.com/questions/30265327/react-js-and-proptypes-repetition-across-shared-components

acceptance criteria

  • buttonprops & image props are in a separate global props file and imported across all components that use them
@summer-cook summer-cook changed the title Fix Button Proptypes linting issue Fix Button Proptypes linting issue/ Global Props Jan 31, 2023
@alishaevn
Copy link
Contributor

re: "'next' should be listed in the project's dependencies." >> https://stackoverflow.com/a/67709545/8079848

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants