You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
See Event-centric arithmetic, in particular multiplication and division. Currently this only supports multiplication and division.
Suggestion
I suggest to extend this for addition and subtraction.
Motivation
For WFM stitching we are currently using an approach where we bin the data, apply a bin-centric operation, then concat. This is actually quite slow, and I think it can be done much simpler using time_of_flight = da.bins.coords['time_offset'].bins + sc.lookup(subframe_offset). This also appears to be faster (on synthetic data).
What needs to be done
Add support for + and -. This should be simple.
Add support for operating on Variable instead of DataArray. Currently we use the coord to lookup the bin in the lookup table and operate on the data values. In this case we want to use the variable for lookup as well as the operation. This could be done in the Python layer by creating a temporary data array (no copy needed).
2.) is probably optional, since this can be done on the user side.
The text was updated successfully, but these errors were encountered:
Context
See Event-centric arithmetic, in particular multiplication and division. Currently this only supports multiplication and division.
Suggestion
I suggest to extend this for addition and subtraction.
Motivation
For WFM stitching we are currently using an approach where we bin the data, apply a bin-centric operation, then
concat
. This is actually quite slow, and I think it can be done much simpler usingtime_of_flight = da.bins.coords['time_offset'].bins + sc.lookup(subframe_offset)
. This also appears to be faster (on synthetic data).What needs to be done
+
and-
. This should be simple.Variable
instead ofDataArray
. Currently we use the coord to lookup the bin in the lookup table and operate on the data values. In this case we want to use the variable for lookup as well as the operation. This could be done in the Python layer by creating a temporary data array (no copy needed).2.) is probably optional, since this can be done on the user side.
The text was updated successfully, but these errors were encountered: