Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated binning functions / arguments #3409

Closed
jl-wynen opened this issue Mar 18, 2024 · 1 comment · Fixed by #3420
Closed

Remove deprecated binning functions / arguments #3409

jl-wynen opened this issue Mar 18, 2024 · 1 comment · Fixed by #3420
Assignees
@MridulS
Labels
good first issue

Comments

@jl-wynen
Copy link
Member

jl-wynen commented Mar 18, 2024 •
edited

There are a number of deprecated functions and arguments for binning/histogramming. We did not set a removal date. But since it has been 2 years, I think we are good to remove them.

In src/core/binning.py.

  • Remove deprecated arg in rebin
  • Remove histogram function

In src/core/bins.py:

  • GroupbyBins.concat; it looks like we can remove GroupbyBins entirely.
@nvaytet
Copy link
Member

nvaytet commented Apr 4, 2024

Can add in the description which ones should be removed or where to find them? So that someone new to the project can attempt this? Thanks!

@jokasimr jokasimr assigned jokasimr and unassigned jokasimr Apr 8, 2024
@MridulS MridulS mentioned this issue Apr 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MridulS MridulS

Labels
good first issue
Projects
Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: Remove deprecated binnings methods and args MridulS/scipp
4 participants
@MridulS @jl-wynen @jokasimr @nvaytet