Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider aborting on errors after calling user-supplied callback. #87

Open
paulmer opened this issue Mar 31, 2020 · 0 comments
Open

Consider aborting on errors after calling user-supplied callback. #87

paulmer opened this issue Mar 31, 2020 · 0 comments

Comments

@paulmer
Copy link

paulmer commented Mar 31, 2020

Calling cb(errmsg) before the user supplied callback to the gulp-clean-css plugin deprives the callback of the opportunity to process or display the warning and error messages generated by the CleanCSS library. Deferring the error until after the callback is executed will make the diagnostic information in the errors and warnings useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant