Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect typing for KeyEvents #144

Open
andyrichardson opened this issue Jun 24, 2019 · 1 comment · May be fixed by #145
Open

Incorrect typing for KeyEvents #144

andyrichardson opened this issue Jun 24, 2019 · 1 comment · May be fixed by #145
Labels
help wanted

Comments

@andyrichardson
Copy link

Key events such as onKeyPress have the wrong types

'(k: Editor, e: KeyboardEvent) => void' is not assignable to type 'DomEvent'.
@andyrichardson andyrichardson linked a pull request Jun 24, 2019 that will close this issue
Open
@scniro
Copy link
Owner

scniro commented Jan 19, 2020

@andyrichardson I am a lot shorter on time these days as when I started this project. Codemirror & React APIs are moving to quickly for me to keep atop of for the day-to-day. I am looking for a co-maintainer of this project. Please contact me directly if you are interested. Thank you for understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix kb types
2 participants
@andyrichardson @scniro