Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spidermon's FileReport does not support Chinese #259

Open
bytebuff opened this issue Jul 3, 2020 · 2 comments
Open

Spidermon's FileReport does not support Chinese #259

bytebuff opened this issue Jul 3, 2020 · 2 comments

Comments

@bytebuff
Copy link

bytebuff commented Jul 3, 2020

Hi, I'm creating a report using spidermon's CreateFileReport：

class SpiderCloseMonitorSuite(MonitorSuite):
    monitors = [ItemCountMonitor, ItemValidationMonitor, PeriodicJobStatsMonitor]

    monitors_finished_actions = [CreateFileReport]

But it turns out that Chinese is not supported，I know this is caused by jinja2。So I changed the encoding in the default template。utf-8 -> gb18030

Python37\Lib\site-packages\spidermon\contrib\actions\reports\templates\reports\email\bases\report\base.jinja

<html>
    <head>
        <meta charset="gb18030">
        <style>
            {% include 'reports/email/bases/report/email.css' %}
            {% include 'reports/email/bases/report/report.css' %}
            {% block page_styles %}
            {% endblock %}
        </style>
    </head>
    <body>
        <table class="report-container" width="100%" border="0" cellspacing="0" cellpadding="0">
            <tr>
                <td align="center">
                    <div class="report {% block page_class %}{% endblock %}">
                        {% block page_content %}{% endblock %}
                    </div>
                    <div class="report-footer">
                        Report timestamp: {{ datetime.datetime.utcnow().strftime('%x %X UTC') }}
                    </div>
                </td>
            </tr>
        </table>
    </body>
</html>

then it works。
@Gallaecio
Copy link
Member

Gallaecio commented Jul 6, 2020 •
edited

Are you sure you are writing your Chinese text in UTF-8? Any chance you can provide a minimal, reproducible example?

@starrify
Copy link
Member

starrify commented Jul 6, 2020

So I changed the encoding in the default template。utf-8 -> gb18030

It is expected that if you decide to use GB18030 (or any other non-UTF-8 encoding), you'll need to have the full chain (content, template, code, browser, etc.) configured in this specific encoding as well.

Similar to Scrapy or many Python libraries, Spidermon by default supports UTF-8 only. I assume that it shall work properly if your content in Chinese (or any other language) is prepared in UTF-8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@starrify @Gallaecio @bytebuff