Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks are outdated #446

Open
lukeawyatt opened this issue Jul 1, 2022 · 2 comments
Open

Benchmarks are outdated #446

lukeawyatt opened this issue Jul 1, 2022 · 2 comments

Comments

@lukeawyatt
Copy link

This is low priority

The benchmarks contained the benchmarks.md markup page in the docs are a number of years dated as of now. They're likely due to be updated with new statistics, versions, and renderings. This is one of the first stops for new users, so it'd just be good to keep it up to date. I'm not versed on alternate libraries, but if there are any new big players, now is a good time to add them into the mix.

I appreciate everyone's work on this project.

~LW

@xoofx
Copy link
Member

xoofx commented Jul 1, 2022

Agreed.

Some background context for the readers:

What happened also is that over time, lots of features have been added and no work on improving the performance has been done to compensate the new features. So before doing anykind of benchmark, quite some work would be required to optimize again the library the same way it was optimized originally.

For example, Fluid folks spent some time not long ago to optimize their library to the point where it is definitely now faster than Scriban, and then, they updated their benchmarks (there was a PR to update the benchmark here but I declined, for the reason that I would update once I have worked on improving the performance again 😅 ).

Also, if you are looking for the fastest Liquid engine (and also more accurate), I would choose Fluid over Scriban without blinking. The support for Liquid in Scriban was mostly an honeypot to increase adoption and help in the transition. But if you come to Scriban, it's not for Liquid, because Scriban was actually built to remove all the awful limitations of Liquid. 😅

@xoofx
Copy link
Member

xoofx commented Jul 1, 2022

Oh, forgot to mention that if anyone want to work on improving performance, PR are welcome! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants