New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request: Bring back the Tonal export #179
Comments
Previous issue/PR for context:
We were technically exposing only one function from |
Hello @mickmister, apologies for the delay in responding here (I was a bit under the weather).
There were a coupla reasons for this,
As for bringing back tonal in either harmonics or Scribbletune, I believe this might not be necessary as Scribbletune will still recognize the scale as an array as before, hence if you simply use tonal as part of your project, you should be able to pass on arrays generated from tonal to Scribbletune. |
@mickmister I almost missed this ^ but, I think it s a good idea and we should come up with an interface via harmonics to do this in a tonal agnostic way. harmonics already has a simplified mapper that accepts a string of 0s and 1s to construct scales. Later it uses this string to construct the scale from a chromatic scale. It does the same for chords too. What are your thoughts on trying to augment a tonal agnostic way of adding on more scales/chords via harmonics? |
For a short time, we were exposing the instance of
tonal
being used byscribbletune
, so an application could interact with the "state" of that instance of the library. Thetonal
dependency has since moved to https://github.com/scribbletune/harmonicsWhat do you think about
harmonics
exporting its instance oftonal
is using toscribbletune
, andscribbletune
exporting the instance as well? It's a bit hacky, but this unlocks way more potential for different scales and chord shapes that an application wants to use (a requirement in my case). I'm definitely open to alternative/proper solutions of accessing the same instance of the library.The text was updated successfully, but these errors were encountered: