Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Tone module won't work with Scribbletune :( #89

Open
FossPrime opened this issue Jul 23, 2019 · 2 comments
Open

FR: Tone module won't work with Scribbletune :( #89

FossPrime opened this issue Jul 23, 2019 · 2 comments

Comments

@FossPrime
Copy link

FossPrime commented Jul 23, 2019

Sample and Reproduction:

Live Code: https://codesandbox.io/s/scribble-bug-tone-not-defined-3859w
Live Demo (see console errors): https://3859w.codesandbox.io/

Steps to Reproduce:

  1. Hit play

Suggested solution

Can we make Tune a clip option, like synth... Corrupting and stepping on global objects is bad news.

Errors:

  1. Without hacking the tone module into the window object, Tone not defined
  2. With the window global hack: Cannot read property 'input' of undefined
@walmik
Copy link
Collaborator

walmik commented Jul 28, 2019

@rayfoss Thank you for pointing this out and even setting up a codesandbox! I ll look into this as soon as I get some time.

@Saktawdi
Copy link

现在这个问题怎么样了,我同样使用的vue,调用scribble.clip(...).start 会报错:is not a function。这不得不让我用tone写一个算法来适配clip数组。
Machine Translation:
How about this problem now? I also use vue, calling scribble.clip(...).start will report an error: is not a function.This had to let me write an algorithm with tone to adapt the clip array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants