Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to move @types/koa to devDependencies #230

Closed
imballinst opened this issue Nov 6, 2023 · 1 comment
Closed

Consider to move @types/koa to devDependencies #230

imballinst opened this issue Nov 6, 2023 · 1 comment
Labels

Comments

@imballinst
Copy link

Hello! Thanks for creating this library, it's super helpful.

I have a question about this part:

"dependencies": {
"@types/koa": "^2.13.9",
"handlebars": "^4.7.8",
"lodash": "^4.17.21",
"read-pkg-up": "7.0.1"
},

Would it make more sense to move it to devDependencies? Because dependencies are transitive dependencies, which are also installed when we install koa-swagger-ui, hence it may cause multiple copies of @types/koa. Maybe a good reference: https://issuu.com/johan.corrales.teams.test.1/docs/effective_typescript/s/16753105

Feel free to close if this is an invalid request, or if it doesn't make sense. Thanks!

Copy link

github-actions bot commented Nov 6, 2023

🎉 This issue has been resolved in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant