Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: minor issue - toast notifications all start with "Close" in screen reader #985

Open
patrickhlauke opened this issue Mar 19, 2023 · 0 comments

Comments

@patrickhlauke
Copy link
Contributor

patrickhlauke commented Mar 19, 2023

Copied over from bitwarden/clients#3488

Steps To Reproduce

  1. Run a screen reader (e.g. NVDA)
  2. Trigger a toast/notification

Expected Result

The toast/notification message should be announced by assistive technologies.

Actual Result

While the toast/notification does announce, it also announces the "Close" button at the start of the notification. All toasts essentially start with "Close ..." and then the actual message. Suggest perhaps tweaking this somehow to only announce the message itself as part of the toast, or reordering the content so that the "X" close button comes after the actual message, at the end of the toast, so each toast starts with the important info first.

Screenshots or Videos

Video showing the issue in Bitwarden, which uses ngx-toastr, on Windows desktop with NVDA, with the notification announcing "Close ..." followed by the message

bitwarden-desktop-toast-close.mp4

Further info

this will depend on the flavour/style of notification. The was filed for the standard (not custom) themed toasts that you get out of the box https://ngx-toastr.vercel.app/ ... themed ones may also have the issue depending on the theme/template they use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant