Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not compare SSTable checksums for 2024.1 backups #3827

Open
karol-kokoszka opened this issue Apr 25, 2024 · 1 comment
Open

Do not compare SSTable checksums for 2024.1 backups #3827

karol-kokoszka opened this issue Apr 25, 2024 · 1 comment
Assignees
Milestone

Comments

@karol-kokoszka
Copy link
Collaborator

Scylla Enterprise 2024.1 introduced as a default support for UUIDs in SSTable names.
scylladb/scylladb#13932

Scylla manager no longer needs to compare checksums when copying files from local to storage, as the SSTable uniqueness is guaranteed by the UUID and the situation where SSTable have the same name and size, but different content is mitigated.

The above is valid for backups made on >= 2024.1 only.
We still need to support old approach for older Scyllas.

Issue on QA side https://github.com/scylladb/qa-tasks/issues/1397

More details of why we have to add this support is here https://github.com/scylladb/scylla-enterprise/issues/4126#issuecomment-2075049181

@karol-kokoszka
Copy link
Collaborator Author

grooming notes

We must check the version of Scylla that we perform the backup task against.
If the version uses UUID in the SSTable names, (>= 2024.1) then we must disable checksum comparision during the move operation performed by RClone.

(per @Michal-Leszczynski) We can check at runtime if the SSTable name includes the UUID or not. If it's not, then we must enable checksum, if it is, we must disable.

@karol-kokoszka karol-kokoszka added this to the 3.2.9 milestone Apr 29, 2024
@mykaul mykaul added the high label May 21, 2024
@Michal-Leszczynski Michal-Leszczynski self-assigned this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants