Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test enterprise nightly #3843

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

Michal-Leszczynski
Copy link
Collaborator

@Michal-Leszczynski Michal-Leszczynski commented May 9, 2024

This PR introduces new restore test framework (testHelper) and (with its help) implements a functional test for restoring a user ( TestRestoreTablesUserIntegration).

It also:
Fixes #3833

Up to this point we didn't specifically set tombstone_gc mode in tests and expected it to be 'timeout'. Since tablet tables need to have tombstone_gc 'repair', we should change the default expectation to it.
Note that this 'assumption' should be removed in the future in favor of something more robust.
@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/test-enterprise-nightly branch 2 times, most recently from 7c64299 to f702253 Compare May 22, 2024 14:03
Ent Scylla versions contain additional table "dicts" which cannot be found in OSS Scylla,
so it should be excluded when comparing GetTarget output with golden files.
@Michal-Leszczynski Michal-Leszczynski force-pushed the ml/test-enterprise-nightly branch 4 times, most recently from 1403cf8 to 200040b Compare May 24, 2024 12:02
ValidateTable was introduced as a workaround for errors encountered from COUNT(*), but it is no longer needed.
This commit also introduces slight groundwork needed for improved restore test framework.
TestHelper is a reimplementation of restoreTestHelper which wasn't well-designed. It removes a lot of boilerplate from test setup and also allows for more flexibility.
This test was previously failing because it's not possible to create non replicated table with tombstone_gc mode repair. This is a good opportunity to use new testHelper framework.
Starting with Scylla 6.0, system_auth is moved to system/system_auth_v2 and is handled by raft.
New clusters won't have the old system_auth tables, so the tests should be adjusted accordingly.
This test stops and starts Scylla service on a node, and it could happen that this node is not fully responsive when the next test is already running. Running this test at the end removes the races between service start and next test execution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Scylla Nightly from PR GH actions
1 participant