Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Scylla Nightly from PR GH actions #3833

Open
karol-kokoszka opened this issue May 6, 2024 · 2 comments · May be fixed by #3843
Open

Remove Scylla Nightly from PR GH actions #3833

karol-kokoszka opened this issue May 6, 2024 · 2 comments · May be fixed by #3843
Assignees

Comments

@karol-kokoszka
Copy link
Collaborator

Scylla Nightly may not be fully stable.
Example of failing repair against Scylla Nightly https://github.com/scylladb/scylla-manager/actions/runs/8925245333/job/24517270900?pr=3832

We must test against fully releases or release candidates only.

@Michal-Leszczynski
Copy link
Collaborator

Mentioned test fails because of #3834, not Scylla Nightly on its own - but I agree that it would be good to have some more stable Scylla version in gh test matrix.

@mykaul
Copy link
Contributor

mykaul commented May 7, 2024

I disagree, we need to test against master. We can pick master that passed CI of course. @yaronkaikov can help with that.

yaronkaikov added a commit to yaronkaikov/scylla-manager that referenced this issue May 7, 2024
Setting the nightly tests to run against the latest scylla-enterpise
nightly container rather then a specific version from OSS

Fixes: scylladb#3833
yaronkaikov added a commit that referenced this issue May 7, 2024
Setting the nightly tests to run against the latest Scylla-enterprise nightly container rather than a specific version from OSS

Fixes: #3833
@yaronkaikov yaronkaikov self-assigned this May 7, 2024
yaronkaikov added a commit to yaronkaikov/scylla-manager that referenced this issue May 7, 2024
Setting the nightly tests to run against the latest Scylla-enterprise nightly container rather than a specific version from OSS

Fixes: scylladb#3833
@Michal-Leszczynski Michal-Leszczynski linked a pull request May 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants