mutation_fragment_stream_validating_filter: respect validating_level::none #18667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r ctor parameter When set to false, no exceptions will be raised from the validator on validation error. Instead, it will just return false from the respective validator methods. This makes testing simpler, asserting exceptions is clunky. When true (default), the previous behaviour will remain: any validation error will invoke on_internal_error(), resulting in either std::abort() or an exception.
…level::none Despite its name, this validation level still did some validation. Fix this, by short-circuiting the catch-all operator(), preventing any validation when the user asked for none.
…on levels To make sure that the validator doesn't validate what the validation level doesn't include.
denesb
added
backport/5.2
raphaelsc
approved these changes
May 14, 2024
🟢 CI State: SUCCESS✅ - Build Build Details:
|
|
Looks good. |
bhalevy
approved these changes
May 15, 2024
|
@scylladb/scylla-maint - please review and merge if approved. |
nyh
approved these changes
May 16, 2024
1 task
This was referenced May 17, 2024
Merged
denesb
added a commit
that referenced
this pull request
May 20, 2024
…pect validating_level::none' from ScyllaDB Even when configured to not do any validation at all, the validator still did some. This small series fixes this, and adds a test to check that validation levels in general are respected, and the validator doesn't validate more than it is asked to. Fixes: #18662 (cherry picked from commit f6511ca) (cherry picked from commit e7b0769) (cherry picked from commit 78afb36) Refs #18667 Closes #18724 * github.com:scylladb/scylladb: test/boost/mutation_fragment_test.cc: add test for validator validation levels mutation: mutation_fragment_stream_validating_filter: fix validation_level::none mutation: mutation_fragment_stream_validating_filter: add raises_error ctor parameter
denesb
added a commit
that referenced
this pull request
May 27, 2024
…pect validating_level::none' from ScyllaDB Even when configured to not do any validation at all, the validator still did some. This small series fixes this, and adds a test to check that validation levels in general are respected, and the validator doesn't validate more than it is asked to. Fixes: #18662 (cherry picked from commit f6511ca) (cherry picked from commit e7b0769) (cherry picked from commit 78afb36) Refs #18667 Closes #18723 * github.com:scylladb/scylladb: test/boost/mutation_fragment_test.cc: add test for validator validation levels mutation: mutation_fragment_stream_validating_filter: fix validation_level::none mutation: mutation_fragment_stream_validating_filter: add raises_error ctor parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when configured to not do any validation at all, the validator still did some. This small series fixes this, and adds a test to check that validation levels in general are respected, and the validator doesn't validate more than it is asked to.
Fixes: #18662