Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintenance socket: provide a default path #18668

Open
piodul opened this issue May 14, 2024 · 9 comments
Open

maintenance socket: provide a default path #18668

piodul opened this issue May 14, 2024 · 9 comments
Assignees
Labels
P2 High Priority
Milestone

Comments

@piodul
Copy link
Contributor

piodul commented May 14, 2024

The maintenance socket, introduced in #16172, provides a CQL interface through a Unix socket. Its intention is to allow administrative access.

However, the socket is not enabled by default. Initially, we wanted to have a default path but it was decided otherwise on the PR (discussion starts here: #16172 (comment)). We would like to revisit this decision.

One of the reasons that we want to reconsider is schema backup for Scylla Manager. Until now, SM has been saving sstables of the schema tables as a way to backup schema, but this method doesn't work with raft-based schema. We would like it to switch to using DESCRIBE SCHEMA WITH INTERNALS command via maintenance socket. However, because the maintenance socket is not enabled by default, the switch to the new method is not seamless as it requires additional configuration changes from the users.

@kbr-scylla
Copy link
Contributor

Due to the SM backup issue, marking this as release blocker. (@mykaul please review the decision.)

@kbr-scylla kbr-scylla added the status/release blocker Preventing from a release to be promoted label May 14, 2024
@kbr-scylla kbr-scylla added this to the 6.0 milestone May 14, 2024
@gleb-cloudius
Copy link
Contributor

Why do you have to use maintenance socket as opposite to regular connection?

@piodul
Copy link
Contributor Author

piodul commented May 21, 2024

AFAIK regular connections may require authentication while the maintenance socket does not. Providing CQL credentials for Scylla Manager is optional.

@mykaul
Copy link
Contributor

mykaul commented May 21, 2024

AFAIK regular connections may require authentication while the maintenance socket does not. Providing CQL credentials for Scylla Manager is optional.

I personally would make it mandatory (@tzach - unsure if we reached a decision here).

@piodul - is there a patch for this? (I know we are still waiting for gocql to support this!)

@piodul
Copy link
Contributor Author

piodul commented May 21, 2024

I personally would make it mandatory (@tzach - unsure if we reached a decision here).

@piodul - is there a patch for this? (I know we are still waiting for gocql to support this!)

@mykaul Do you mean making it mandatory to provide CQL credentials for SM? AFAIK if SM uses the Unix socket then credentials will not be mandatory.

As for the support for the Unix socket in SM, there is the issue scylladb/scylla-manager#3831 but no patches yet.

@mykaul
Copy link
Contributor

mykaul commented May 21, 2024

@piodul - patch to providing a default path to the maint. socket.

@piodul
Copy link
Contributor Author

piodul commented May 21, 2024

@piodul - patch to providing a default path to the maint. socket.

It looks like there isn't one yet.
Just to be clear - this task is currently in @kbr-scylla's team scope, core-backend is not working on this.

@tzach
Copy link
Contributor

tzach commented May 26, 2024

Lets assume Manager / Admin has premission during restore / backup

@tzach tzach modified the milestones: 6.0, 6.1 May 26, 2024
@kbr-scylla
Copy link
Contributor

Taking off release blocker label then.

@kbr-scylla kbr-scylla added P2 High Priority and removed status/release blocker Preventing from a release to be promoted labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High Priority
Projects
None yet
Development

No branches or pull requests

6 participants