Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update Tablet information in the CREATE KEYSPACE section #18670

Open
Tracked by #18597
annastuchlik opened this issue May 14, 2024 · 4 comments · May be fixed by #19063
Open
Tracked by #18597

doc: update Tablet information in the CREATE KEYSPACE section #18670

annastuchlik opened this issue May 14, 2024 · 4 comments · May be fixed by #19063
Assignees
@xemul @bhalevy @annastuchlik
Labels
area/tablets backport/6.0 documentation Requires documentation
Milestone
6.0

Comments

@annastuchlik
Copy link
Collaborator

As tablets are configured per keyspace, the following section needs to be updated:
https://opensource.docs.scylladb.com/master/cql/ddl.html#the-tablets-property-experimental

This issue is a release blocker. Tablets are no longer experimental in 6.0.
@annastuchlik annastuchlik added documentation Requires documentation area/tablets labels May 14, 2024
@annastuchlik annastuchlik added this to the 6.0 milestone May 14, 2024
@annastuchlik annastuchlik added the backport/none Backport is not required label May 14, 2024
@annastuchlik
Copy link
Collaborator Author

@bhalevy @tgrabiec I've assigned you to this issue, too, so that the documentation is updated together with the code.
If it's not, I can open a separate PR, but this update mus be made before 6.0 is released.

@bhalevy bhalevy assigned xemul and unassigned tgrabiec May 23, 2024
@bhalevy
Copy link
Member

bhalevy commented May 23, 2024

Reassigned to @xemul to balance the load.
Please review the documentation and see what exactly needs to change.

@annastuchlik annastuchlik added backport/6.0 and removed backport/none Backport is not required labels May 23, 2024
@annastuchlik
Copy link
Collaborator Author

@bhalevy Great! It would be great to have #18619 merged and cross-link the main doc about tablets with the CREATE KEYSPACE section about tablets.

@annastuchlik annastuchlik mentioned this issue May 23, 2024
Open
@annastuchlik
Copy link
Collaborator Author

@xemul What's the status? This is something we need to have documented before we release 6.0. I'd like to open a PR, but I need to understand what needs to be changed (apart from lifting the "experimental" limitation).

@annastuchlik annastuchlik mentioned this issue May 27, 2024
Closed
annastuchlik added a commit to annastuchlik/scylladb that referenced this issue Jun 3, 2024
@annastuchlik
doc: mark tablets as GA in the CREATE KEYSPACE section
0c83b98 
This commit removes the information that tablets are an experimental feature
from the CREATE KEYSPACE section.

In addition, it removes the notes and cautions that are redundant when
a feature is GA, especially the information and warnings about the future
plans.

Fixes scylladb#18670
@annastuchlik annastuchlik linked a pull request Jun 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xemul xemul

@bhalevy bhalevy

@annastuchlik annastuchlik

Labels
area/tablets backport/6.0 documentation Requires documentation
Projects
None yet
Milestone
6.0
Development

Successfully merging a pull request may close this issue.

doc: mark tablets as GA in the CREATE KEYSPACE section annastuchlik/scylladb
4 participants
@tgrabiec @xemul @bhalevy @annastuchlik