Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tablet_incremental_selector should be configured only with ranges within this replica #18684

Open
Deexie opened this issue May 15, 2024 · 2 comments

Comments

@Deexie
Copy link
Contributor

Deexie commented May 15, 2024

Currently tablet_incremental_selector returns empty sstables vector if a range is not on this replica. It should not need to check the tablet's existence.

The responsibility for generating ranges fully contained within one tablet and skipping the empty one should rather be put on caller.

See discussion #17664 (comment) for the details.

@bhalevy
Copy link
Member

bhalevy commented May 15, 2024

What's the severity of this issue?
That it cause any problem other than inefficiency?
and if so, how bad is it?

@raphaelsc
Copy link
Member

What's the severity of this issue? That it cause any problem other than inefficiency? and if so, how bad is it?

I think the most important thing is to unlock the ability to detect that a tablet is not present, during range scans, so we fail rather than returning wrong empty data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants