Fix array indexing and length handling #1274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cf. https://sdkman.slack.com/archives/CJTNQA94M/p1706573532033689?thread_ts=1706516271.626039&cid=CJTNQA94M - Array indexing is wrong, it starts at 1 (not 0) and ends at the highest index, not at array length -1. You have both in C or Java, but shell is different. - Executed in bash the `${#versions}` is - for whatever reason - restricted to four bits. So the maximum value is 15. If the versions array is > 15, you have to use `${#versions[@]}` instead (cf. https://linuxhandbook.com/array-length-bash/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. https://sdkman.slack.com/archives/CJTNQA94M/p1706573532033689?thread_ts=1706516271.626039&cid=CJTNQA94M
${#versions}is - for whatever reason - restricted to four bits. So the maximum value is 15. If the versions array is > 15, you have to use${#versions[@]}instead (cf. https://linuxhandbook.com/array-length-bash/).NOTE: I have no idea how to provide a Cucumber test for this case. But I am happy to learn about it, in particular how to test the array size in bash if it is > 15. Feel free to get in touch with me about it.
Fixes #1273