Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slack-catalog cache TTL #47

Open
crivetechie opened this issue Mar 21, 2024 · 4 comments
Open

slack-catalog cache TTL #47

crivetechie opened this issue Mar 21, 2024 · 4 comments

Comments

@crivetechie
Copy link

Hi! Thanks for creating this set of plugins! I am looking at using slack-catalog, it works great however it doesn't seem to have a TTL on the cache, I think it would be great if you could add a TTL config parameter so that new slack members can be loaded.

@zhammer
Copy link
Contributor

zhammer commented Mar 21, 2024

this'd be great! it also may make sense to use Backstage's proper caching solution here.

would appreciate a PR on this one. our slack org doesn't change too often so this isn't high prio for us

@crivetechie
Copy link
Author

I think I can take a look, do you have a reference I can take a look at to see how to implement Backstage caching? Thanks!

@zhammer
Copy link
Contributor

zhammer commented Mar 21, 2024

on a quick look i find this: https://backstage.io/docs/reference/backend-plugin-api.cacheservice/

although in the slack catalog case, the "cache" isn't really a proper cache, it's just there so there can be one user list call to the slack api rather than getting each user individually. this makes sense for us because users come only from our okta provider on a schedule, so every 24hr we'll get an influx of new users all getting processed at once. so in our case just dropping that cache even after a few minutes from it being loaded would be fine (once all the okta ingested users are processed).

how does your org ingest users?

@crivetechie
Copy link
Author

Yeah it makes sense to cache that way, we just need to expire it.
We ingest users using the GitHub Org Provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants