New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explore using fopen() instead of is_file() and file_get_contents() for static analysis cache #825

Open

sebastianbergmann opened this issue Oct 10, 2020 · 1 comment

Assignees

Labels

performance type/enhancement

Owner

sebastianbergmann commented Oct 10, 2020

@johannes mentioned:

Try opening it using fopen() or similar. If that fails the file isn't in cache and you can take that path. If it succeeds you can process the cache directly or keep the file handle around for a short while. In the case the file is in cache this becomes a single access (plus reads) instead of two and directly verifies all permissions etc.

sebastianbergmann added enhancement performance labels

sebastianbergmann self-assigned this

Owner Author

sebastianbergmann commented Feb 21, 2022

@Slamdunk What do you think?

sebastianbergmann added type/enhancement and removed enhancement labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment