Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate support for using comma-separated values with the --group, --exclude-group, --covers, --uses, and --test-suffix CLI options #5709

Closed
sebastianbergmann opened this issue Feb 18, 2024 · 0 comments
Closed

Deprecate support for using comma-separated values with the --group, --exclude-group, --covers, --uses, and --test-suffix CLI options #5709

sebastianbergmann opened this issue Feb 18, 2024 · 0 comments
Assignees
@sebastianbergmann
Labels
feature/configuration/cli feature/test-runner CLI test runner type/deprecation Something will be/is deprecated
Milestone
PHPUnit 11.1

Comments

@sebastianbergmann
Copy link
Owner

The --group, --exclude-group, --covers, --uses, and --test-suffix CLI options support comma-separated values.

For instance, --group foo,bar can be used to run the tests from the foo and bar groups. After #5708, --group foo --group bar should be used instead.
@sebastianbergmann sebastianbergmann added this to the PHPUnit 11.1 milestone Feb 18, 2024
@sebastianbergmann sebastianbergmann self-assigned this Feb 18, 2024
@sebastianbergmann sebastianbergmann mentioned this issue Feb 18, 2024
Open
sebastianbergmann added a commit that referenced this issue Feb 18, 2024
@sebastianbergmann
Closes #5708 and #5709
129106b
@cookieguru cookieguru mentioned this issue Apr 12, 2024
Merged
g105b pushed a commit to php-actions/phpunit that referenced this issue Apr 16, 2024
@cookieguru
Remove the default value for the test_suffix parameter (#64)
1789d19 
Passing a comma-separated list of values to the CLI argument
--test-suffix has been deprecated in PHPUnit 11[1] and will no longer
work in PHPUnit 12.  Given that this action is sending its default
value[2] anyways, there's no reason to explicitly provide this command
line argument.  Further, it's confusing that this command line argument
is specified at all when nothing in my repo's configuration sets its
value.

[1]: sebastianbergmann/phpunit#5709
[2]: https://docs.phpunit.de/en/11.1/textui.html#selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastianbergmann sebastianbergmann

Labels
feature/configuration/cli feature/test-runner CLI test runner type/deprecation Something will be/is deprecated
Projects
None yet
Milestone
PHPUnit 11.1
Development

No branches or pull requests
1 participant
@sebastianbergmann