You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Despite that all calls to the library return promises, the promises themselves are blocking, defeating much of the purpose of having them in the first place.
The reason they are blocking is because the implementation of systeminformation uses calls like execSync(), instead of just exec() (and then awaiting the result).
To Reproduce
Use-case: Fetching WiFi info running in the electron main process.
Steps to reproduce the behavior:
Issue await si.wifiNetworks(), assuming it will take long time (several seconds).
While waiting for the info, the thread awaiting the network info is blocked from doing other work (even though promises are used).
Expected behavior
I expect that awaiting the result shouldn't be really blocking the thread, just making it available for other tasks to run while awaiting the result.
Environment (please complete the following information)
systeminformation package version: 5.21.18
OS: Linux
Additional information
To always reproduce the problem, simply modify an existing command to something like execSync('sleep 10;' + originalCmd).
Workaround
Put the offending systeminformation call in a worker thread, which can be properly awaited without blocking anything.
The text was updated successfully, but these errors were encountered:
@KristjanESPERANTO: Yes, of course, thank you :) I have corrected the description!
And just to show-case the difference between using execSync and exec, here's an example program when starting a 100 ms timer, but using different strategies depending on if useSync is true or false:
constchild_process=require("child_process")constprocess=require("process")constnow=newDate();setTimeout(()=>{console.log(newDate()-now+" ms elapsed")},100)constuseSync=true;process.nextTick(async()=>{if(useSync){child_process.execSync("sleep 2");}else{awaitchild_process.exec("sleep 2");}})
As can be seen, the timer is prevented from running if we're issuing execSync(), but is allowed to run when calling await exec().
Describe the bug
Despite that all calls to the library return promises, the promises themselves are blocking, defeating much of the purpose of having them in the first place.
The reason they are blocking is because the implementation of systeminformation uses calls like
execSync()
, instead of justexec()
(and then awaiting the result).To Reproduce
Use-case: Fetching WiFi info running in the electron main process.
Steps to reproduce the behavior:
await si.wifiNetworks()
, assuming it will take long time (several seconds).Expected behavior
I expect that awaiting the result shouldn't be really blocking the thread, just making it available for other tasks to run while awaiting the result.
Environment (please complete the following information)
Additional information
To always reproduce the problem, simply modify an existing command to something like
execSync('sleep 10;' + originalCmd)
.Workaround
Put the offending systeminformation call in a worker thread, which can be properly awaited without blocking anything.
The text was updated successfully, but these errors were encountered: