Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Node.js 18 in Docker #468

Closed
1 task
Tracked by #399
azu opened this issue Apr 21, 2023 · 0 comments · Fixed by #540
Closed
1 task
Tracked by #399

Update to Node.js 18 in Docker #468

azu opened this issue Apr 21, 2023 · 0 comments · Fixed by #540
Labels
good first issue Good for newcomers Status: Proposal Request for comments

Comments

@azu
Copy link
Member

azu commented Apr 21, 2023

secretlint/publish/docker/Dockerfile

Line 1 in 18d6b54

FROM node:16-alpine

Node.js 16 will be EOL at 2023-09.
We need to update the base image.

TODO

  • Change to node:18-alpine
@azu azu added good first issue Good for newcomers Status: Proposal Request for comments labels Apr 21, 2023
This was referenced Feb 4, 2023
Closed
Merged
@azu azu linked a pull request Jul 2, 2023 that will close this issue
feat(docker): use Node.js 18 as base image #540
Merged
@azu azu closed this as completed in #540 Jul 2, 2023
@azu azu mentioned this issue Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Status: Proposal Request for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(docker): use Node.js 18 as base image secretlint/secretlint
1 participant
@azu