Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is naive error handling, at least we need to let the user know that they need to refresh the page #131

Open
darioalessandro opened this issue Aug 9, 2023 · 5 comments
Labels
good first issue Good for newcomers

Comments

@darioalessandro
Copy link
Member

          This is naive error handling, at least we need to let the user know that they need to refresh the page

Originally posted by @darioalessandro in #130 (comment)

@darioalessandro darioalessandro added the good first issue Good for newcomers label Aug 9, 2023
@tusharkarle
Copy link

@darioalessandro can i work on the above enhancement and get idea of exactly what is expected here

@darioalessandro
Copy link
Member Author

Heck yeah! Thanks for chiming in! I'll do a write up

@darioalessandro
Copy link
Member Author

Lets start small, how about this:

If we fail to decrypt an aes_packet from a given peer we should have a mechanism to trigger the key exchange.

This is a diagram of how key exchange works:

https://github.com/security-union/videocall-rs/blob/main/sequence-diagram.txt

Untitled

@tusharkarle
Copy link

Ok . will understand the flow and start working on the same

@ronen
Copy link
Collaborator

ronen commented Aug 19, 2023

Hi @tusharkarle just a heads-up, once #137 gets merge (assuming it does :) all the encryption code will have moved from the Attendants component into a new VideoCallClient.

It's all basically the same code, it's just in a new place -- but this new place is behind an API surface, allowing the key exchange to be done "behind the scenes" as far as the UI code is concerned. And providing an opportunity for defining explicit errors/callbacks to be passed to the UI if such turn out to be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants