Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Option to append index.html to routes #193

Open
AndrewLeedham opened this issue Sep 23, 2020 · 4 comments · May be fixed by #195
Open

[Feature Request] Option to append index.html to routes #193

AndrewLeedham opened this issue Sep 23, 2020 · 4 comments · May be fixed by #195

Comments

@AndrewLeedham
Copy link
Contributor

Some hosting environments like Chromatic don't automatically serve index.html from a folder path, e.g <base-url>/playroom/preview would just 404. I raised this issue with Chromatic and they are looking into it, but I thought it would also be useful to fix the problem here so other people can workaround it if their hosting cannot be modified.

I can see 3 paths for supporting this:

  • Updating all the links to include index.html, this could be a breaking change in some cases.
  • Adding an option to include index.html so it is opt-in.
  • Add a previewUrl option so the index.html can be added manually.

Personally I think option 2 makes the most-sense as it is opt-in and can apply to all URLs rather than having a separate option for any new links added in the future.

@AndrewLeedham AndrewLeedham linked a pull request Sep 24, 2020 that will close this issue
@roddds
Copy link

roddds commented Oct 14, 2020

I have the exact same issue with the CircleCI artifacts storage and would very much like to see this merged. Happy to help if help is needed.

@AndrewLeedham
Copy link
Contributor Author

@roddds Not sure there is much you can do. I have put in a PR to fix the issue, just waiting on a PR review from a maintainer. I suppose you could test the implementation in your use-case and provide any feedback there?

@TomHancock2
Copy link

We're experiencing the same issue so would be great if the PR could be progressed.

@AndrewLeedham
Copy link
Contributor Author

If you're using Chromatic I worked with their devs and this is no-longer needed. But would still be useful for other platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants