Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out exports that are not components #246

Open
mihkeleidast opened this issue Sep 30, 2021 · 0 comments
Open

Filter out exports that are not components #246

mihkeleidast opened this issue Sep 30, 2021 · 0 comments

Comments

@mihkeleidast
Copy link
Contributor

Our library exports some helper functions in addition to React components. Playroom does not look at what is exported and adds everything to suggestions:
image

Two possible solutions I see here:

  1. Filter out exports that are not capitalized - AFAIK there is a requirement that all React components start with a capital letter.
  2. Let the user provide a filter function in the config.

Would this be a good improvement and which solution should it use?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mihkeleidast