Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playroom favicon is not customizable #320

Open
marcoskolodny opened this issue Feb 8, 2024 · 0 comments
Open

Playroom favicon is not customizable #320

marcoskolodny opened this issue Feb 8, 2024 · 0 comments

Comments

@marcoskolodny
Copy link

Hello!

I was trying to add a custom favicon to my Playroom website, but I couldn't make it work. After digging into the code, I've noticed that in this PR you are forcing the icon to be the playroom logo.

I believe the playroom logo is nice to have, but the favicon should be customizable. I fully agree with this comment in the PR. Why not allowing users to pass their own favicon through playroomConfig or through the public folder, and using the playroom logo as fallback if the user didn't pass one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant