You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was trying to add a custom favicon to my Playroom website, but I couldn't make it work. After digging into the code, I've noticed that in this PR you are forcing the icon to be the playroom logo.
I believe the playroom logo is nice to have, but the favicon should be customizable. I fully agree with this comment in the PR. Why not allowing users to pass their own favicon through playroomConfig or through the public folder, and using the playroom logo as fallback if the user didn't pass one?
The text was updated successfully, but these errors were encountered:
Hello!
I was trying to add a custom favicon to my Playroom website, but I couldn't make it work. After digging into the code, I've noticed that in this PR you are forcing the icon to be the playroom logo.
I believe the playroom logo is nice to have, but the favicon should be customizable. I fully agree with this comment in the PR. Why not allowing users to pass their own favicon through playroomConfig or through the public folder, and using the playroom logo as fallback if the user didn't pass one?
The text was updated successfully, but these errors were encountered: