Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient WuHostServe is buggy #17

Open
clbr opened this issue Mar 22, 2022 · 1 comment
Open

Efficient WuHostServe is buggy #17

clbr opened this issue Mar 22, 2022 · 1 comment

Comments

@clbr
Copy link

clbr commented Mar 22, 2022

If you call WuHostServe with -1 for the timeout, the most efficient mode where the thread sleeps when there is nothing to do, it's buggy. It results in pruning clients too early, because the dt delta time can end up very large, far larger than the 8s max-ttl set for a client.

It should be documented that the sleep should be below the heartbeat time (4s), as outgoing heartbeats don't flow either in the efficient mode.

@clbr
Copy link
Author

clbr commented Mar 22, 2022

(the lib is also not thread-safe, but I have local mods for that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant