Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Theming documentation, specify which components are unable to have custom appearances and sizes #1594

Open
jasonbarry opened this issue Jan 12, 2023 · 2 comments
Labels
documentation theming Question, feedback, etc. around theming architecture

Comments

@jasonbarry
Copy link
Contributor

https://evergreen.segment.com/introduction/theming

appearances: These are the custom styles that you can apply to a component based on the appearance prop. Note that some components don't have this.

Which ones? Why not?

sizes: These are additional props that you can alias via a size property. Again, note that some components don't have this, and you can only configure baseStyle.

Which components?

@brandongregoryscott brandongregoryscott added documentation theming Question, feedback, etc. around theming architecture labels Jan 12, 2023
@Jittojoyes98
Copy link

Anyone working on this issue?

@brandongregoryscott
Copy link
Contributor

brandongregoryscott commented Jan 19, 2023

Hey @jasonbarry,

Thanks for raising this issue. We've heard from people a lot recently that the theming documentation could be improved, so I opened up a discussion (#1597) to request more specific feedback on where we should be doing 😄

Specifically, there's not a lot of rhyme or reason to why certain components support appearances, what parts of each component are themeable, etc. I think the doc site will need some infrastructure setup to add a "Theming" tab to each component's detail page, similar to the Props table. Ideally this could also read from the component's theme code to provide guidance and reduce the amount of content we need to write for each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation theming Question, feedback, etc. around theming architecture
Projects
None yet
Development

No branches or pull requests

3 participants