Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the right single quotation mark to diactritics. #4337

Merged
merged 1 commit into from Sep 11, 2018

Conversation

charettes
Copy link
Contributor

@charettes charettes commented May 2, 2016

This pull request includes a

  • Bug fix

The following changes were made

  • Added the RIGHT SINGLE QUOTATION MARK character to diacritics

It should be simplified to a typewriter apostrophe: https://en.wikipedia.org/wiki/Apostrophe#Unicode

I could also add all the apostrophe variants but I feel this should be the most common one as this is the preferred character to use for apostrophe according to the Unicode standard.

@kevin-brown kevin-brown added this to the 4.1.0 milestone Jun 11, 2016
@alexweissman
Copy link
Contributor

Failing some jshint checks:

   src/js/[secure]/diacritics.js

    844 |    '\u2019': "'"

                          ^ Strings must use singlequote.

   src/js/[secure]/i18n/lt.js

      2 |  // rules from http://www.unicode.org/cldr/charts/latest/supplemental/language_plural_rules.html#lt

                                                                                                            ^ Line is too long.

      6 |    } else if ((count % 10 >= 2 && count % 10 <= 9) && (count % 100 < 11 || count % 100 > 19)) {

                                                                                                        ^ Line is too long.

>> 3 errors in 92 files

Warning: Task "jshint:code" failed.� Use --force to continue.

@charettes
Copy link
Contributor Author

@alexweissman just pushed an adjusted commit.

It should be simplified to a typewriter apostrophe.
@alexweissman
Copy link
Contributor

Oh, awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants