Fix AJAX data source error #4356

MichaelMackus · 2016-05-11T22:59:57Z

This pull request includes a

Bug fix

The following changes were made

Check for existence of "status" in the $request object (instead of truthfulness)
Check that $request.status === 0 (number) not '0' (string)

Fixes #4355

Verified in Firefox & Chromium

Fixes select2#4355 Verified in Firefox & Chromium

PowerKiKi · 2016-07-19T11:29:34Z

I believe this the solution to a bug that is affecting all installation of select2. As such, shouldn't it be released in a patch version (4.0.4), rather than a minor version (4.1.0) ?

It seems that including this for 4.1 is only delaying the fix without any other benefits. I don't think it's either a breaking change or a new feature.

kevin-brown · 2016-07-19T13:44:54Z

@PowerKiKi the next planned release of Select2 is 4.1.0, we have no intentions of rolling a 4.0.4 release due to (outside) time constraints.

PowerKiKi · 2016-07-19T15:24:16Z

Not quite what I wanted to hear, but thanks for taking the time to answer anyway 👍

drmmr763 · 2017-01-23T15:54:55Z

Currently experiencing bug #4355. Would love to see this PR merged or the next release rolled out so I can upgrade. Probably going to apply this patch anyway for the time being. But +1 this PR!

MichaelMackus · 2017-01-23T17:17:21Z

👍 for a new minor version increase. This is a bugfix affecting most/all modern browsers!

PowerKiKi · 2017-01-24T02:45:53Z

It seems that select2 lacks a proper workflow for (semi-)continuous delivery. It's a pity because bugs like these impact a lot of users, yet are very simple and safe to fix. Especially when the community do half the work to fix it.

vlad-datacat · 2017-01-31T06:45:44Z

Any comment on when this will be released? Time frames? Experiencing the 4355 across all devices...

jpic · 2017-02-15T13:33:34Z

We'll need regression tests before we can merge this.

jpic

We'll also need a unit test before we can test this. /A priori/ it would make sense to add a test with request.status being 0 and another one for '0' as a string, and ensure that it works as expected in both cases.

jpic · 2017-02-15T13:32:46Z

dist/js/select2.full.js

@@ -3444,7 +3444,7 @@ S2.define('select2/data/ajax',[
      }, function () {
        // Attempt to detect if a request was aborted
        // Only works if the transport exposes a status property
-        if ($request.status && $request.status === '0') {
+        if ('status' in $request && $request.status === 0) {


Is this not going to break support for all browsers that have '0' ? shouldnt this be $request.status === 0 || $request.status === '0'?

For those who are using timeout : if ('status' in $request && $request.status === 0 && $request.statusText != "timeout")

jpic · 2017-02-15T13:33:05Z

dist/js/select2.js

@@ -3444,7 +3444,7 @@ S2.define('select2/data/ajax',[
      }, function () {
        // Attempt to detect if a request was aborted
        // Only works if the transport exposes a status property
-        if ($request.status && $request.status === '0') {
+        if ('status' in $request && $request.status === 0) {


Don't change dist files, for more info check CONTRIBUTING

jpic · 2017-02-15T13:33:14Z

src/js/select2/data/ajax.js

@@ -82,7 +82,7 @@ define([
      }, function () {
        // Attempt to detect if a request was aborted
        // Only works if the transport exposes a status property
-        if ($request.status && $request.status === '0') {
+        if ('status' in $request && $request.status === 0) {


Same question.

MichaelMackus · 2017-02-20T17:23:36Z

@jpic done & submitted changes. I'm not familiar with JS testing, but will look into if I find some free time. If somebody else could take on the tests I'd be grateful.

alexweissman · 2017-09-11T16:05:06Z

Seems like a pretty popular fix - can someone who knows their way around the testing framework please write some tests so we can get this released in the next revision?

They updated to check for either integer or string values.

…4356)

lordplagus02 · 2017-10-26T09:00:23Z

Just reminding everyone that this exists and it's been over a year. 😞

alexweissman · 2017-10-26T15:40:13Z

@lordplagus02 it will be released in 4.0.6. Hold yer horses 🐴

Actually, I've already merged it into develop if you need to start using it before an official release.

alexweissman · 2017-10-26T17:42:00Z

Merged into develop for 4.0.6 release.

markoheijnen · 2018-09-13T12:40:31Z

Any idea when this is going to be released?

pedrofurtado · 2018-09-13T17:15:16Z

@markoheijnen In next weeks. I am reviewing some another PRs. After it, we will release a version.

smuszel · 2019-06-19T09:38:32Z

Hey. Are you sure this solution indeed fixes the issue. At my company we are still having issues with it. Changing function at 3589 of select.js to below fixed the problem.

function(_, statusText) {
    if (statusText !== 'abort') {
        self.trigger('results:message', {
            message: 'errorLoading',
        });
    }
},

MichaelMackus added 2 commits May 11, 2016 15:58

Fix AJAX data source error

e482efe

Fixes select2#4355 Verified in Firefox & Chromium

Update dist files with bugfix

2ee3542

kevin-brown added the 4.x label May 16, 2016

kevin-brown added this to the 4.1.0 milestone Jun 11, 2016

stephpy mentioned this pull request Jun 21, 2016

AJAX data source "the results could not be loaded" error #4355

Closed

16 tasks

kevin-brown mentioned this pull request Jul 7, 2016

Better detection of aborted ajax queries #4462

Closed

3 tasks

jpic previously requested changes Feb 15, 2017

View reviewed changes

MichaelMackus added 2 commits February 20, 2017 09:18

Revert changes to dist dir

6502b40

Check for string value

180d366

alexweissman added the status: needs additional work label Sep 11, 2017

alexweissman mentioned this pull request Sep 11, 2017

Fix: #4870 — fixed response status check #4882

Closed

alexweissman mentioned this pull request Oct 25, 2017

'The results could not be loaded.' message during typing when request was cancelled by select2 #4870

Closed

alexweissman modified the milestones: 4.1.0, 4.0.6 Oct 26, 2017

alexweissman added a commit that referenced this pull request Oct 26, 2017

Fix "the results could not be loaded" displaying during AJAX request (#…

3d8864b

…4356)

alexweissman removed the status: needs additional work label Oct 26, 2017

alexweissman mentioned this pull request Oct 26, 2017

Fix ajax.abort() detection to handle transport.status code as integer #4758

Closed

3 tasks

alexweissman added the status: resolved label Oct 26, 2017

alexweissman closed this Oct 26, 2017

alexweissman added confirmed bug: resolved and removed status: resolved labels Oct 26, 2017

alexweissman added confirmed bug status: resolved labels Dec 9, 2017

benr77 mentioned this pull request Oct 24, 2018

Data attribute like data-placeholder & other not working after an upgrade to 4.0.6-rc.1 from 4.0.5 #5320

Closed

xl3lackkikx mentioned this pull request Jul 17, 2019

Select2 stops working or starts working on rescale #5572

Closed

This was referenced Apr 8, 2020

[Snyk] Upgrade select2 from 4.0.5 to 4.0.13 ayman-elkassas/Treaty#5

Open

[Snyk] Upgrade select2 from 4.0.5 to 4.0.13 ayman-elkassas/AdminLTE#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix AJAX data source error #4356

Fix AJAX data source error #4356

MichaelMackus commented May 11, 2016 •

edited

PowerKiKi commented Jul 19, 2016

kevin-brown commented Jul 19, 2016

PowerKiKi commented Jul 19, 2016

drmmr763 commented Jan 23, 2017

MichaelMackus commented Jan 23, 2017

PowerKiKi commented Jan 24, 2017

vlad-datacat commented Jan 31, 2017

jpic commented Feb 15, 2017

jpic left a comment

jpic Feb 15, 2017

MaximeCn Jan 23, 2018

jpic Feb 15, 2017

jpic Feb 15, 2017

MichaelMackus commented Feb 20, 2017

alexweissman commented Sep 11, 2017

lordplagus02 commented Oct 26, 2017 •

edited

alexweissman commented Oct 26, 2017 •

edited

alexweissman commented Oct 26, 2017

markoheijnen commented Sep 13, 2018 •

edited

pedrofurtado commented Sep 13, 2018

smuszel commented Jun 19, 2019

Fix AJAX data source error #4356

Fix AJAX data source error #4356

Conversation

MichaelMackus commented May 11, 2016 • edited

PowerKiKi commented Jul 19, 2016

kevin-brown commented Jul 19, 2016

PowerKiKi commented Jul 19, 2016

drmmr763 commented Jan 23, 2017

MichaelMackus commented Jan 23, 2017

PowerKiKi commented Jan 24, 2017

vlad-datacat commented Jan 31, 2017

jpic commented Feb 15, 2017

jpic left a comment

Choose a reason for hiding this comment

jpic Feb 15, 2017

Choose a reason for hiding this comment

MaximeCn Jan 23, 2018

Choose a reason for hiding this comment

jpic Feb 15, 2017

Choose a reason for hiding this comment

jpic Feb 15, 2017

Choose a reason for hiding this comment

MichaelMackus commented Feb 20, 2017

alexweissman commented Sep 11, 2017

lordplagus02 commented Oct 26, 2017 • edited

alexweissman commented Oct 26, 2017 • edited

alexweissman commented Oct 26, 2017

markoheijnen commented Sep 13, 2018 • edited

pedrofurtado commented Sep 13, 2018

smuszel commented Jun 19, 2019

MichaelMackus commented May 11, 2016 •

edited

lordplagus02 commented Oct 26, 2017 •

edited

alexweissman commented Oct 26, 2017 •

edited

markoheijnen commented Sep 13, 2018 •

edited