Trigger 'input' event before 'change' events

[marcandre]

This pull request includes a

• Bug fix
• New feature
• Translation

The following changes were made

• Triggers an input event before triggering a change event
• Tests looking for change event being triggered now look for input then change.

While not widely known, the input event is triggered before all change events for inputs and selects (see the spec here)

FWIW, Parsley relies on the input event, so the current code is causing bad interactions

[kevin-brown]

It's not clear under what cases the input event is fired. Is there a use case for the input event that is not dependent on the change event, or is one basically a copy of the other?

[kevin-brown]

I'm not sure how I feel about enforcing the order of the events within past tests. I can understand adding tests to check that the input event is triggered, and adding tests to ensure that one event is caught before the other, but I don't think that requires you to modify old change-only tests to cover both those cases.

[marcandre]

Thanks for taking a look at this PR 😄

1. Every change event should be preceded by at least one input event. Most inputs have a single input event triggered just before a change event, but some like type="text" usually have many input events (e.g. after each key / paste / ...) before a single change event (when loosing focus). Another input with multiple input events before each change is the type="color".

2. For tests, we could have one test to insure that change is triggered, another to check that input is triggered, and a third one to insure that they are triggered in the right order, but the first two are made redundant by the third one so that why I felt this was the best solution. Note that the order of the event is mandated by the spec.

Let me know how I can be of further assistance

[marcandre]

@kevin-brown Is there something else that is blocking this PR from being merged?

It's been two years.

[marcandre]

I've rebased my branch.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[marcandre]

This PR is really simple, and is still valid.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[marcandre]

This PR is really simple, and is still valid.

[Marco-Sulla]

Please merge this pull request, is simple and adhere to the standards

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[marcandre]

Stale bot: 0
Me: 2

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[marcandre]

Rebased.

[edwinvdpol]

Ow come on, merge already!! 👍

[kevin-brown]

Rebased this pull request against the latest dev so the new checks can run. The goal of this is to get it merged in tonight for the next patch release.

[marcandre]

Cool, thanks!