Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing styling for select2-selection__placeholder class for multi-selects #5094

Closed
alexweissman opened this issue Oct 26, 2017 · 4 comments

Comments

@alexweissman
Copy link
Contributor

I noticed that there are some CSS rules for select2-selection__placeholder in the default theme's SCSS assets:

https://github.com/select2/select2/blob/master/src/scss/theme/default/_multiple.scss#L19-L25
https://github.com/select2/select2/blob/master/src/scss/theme/default/_multiple.scss#L66

But for multi-select, placeholders are always displayed using the placeholder attribute on the search control. So, is there any point to these rules in _multiple.scss?

@kevin-brown
Copy link
Member

As far as I can tell, this class should only ever be used with a single select. So those CSS rules can be safely dropped.

There was a point in time where the multi-select placeholder was not using the placeholder attribute, which would explain why this was necessary at one point.

@alexweissman alexweissman added this to the 4.0.6 milestone Dec 9, 2017
@stale
Copy link

stale bot commented Mar 13, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Mar 13, 2019
@stale stale bot closed this as completed Mar 20, 2019
@kevin-brown kevin-brown reopened this Apr 24, 2019
@kevin-brown kevin-brown removed this from the 4.0.6 milestone Apr 24, 2019
@kevin-brown kevin-brown changed the title Is the select2-selection__placeholder class ever used for multi-selects? Removing styling for select2-selection__placeholder class for multi-selects Apr 24, 2019
@stale
Copy link

stale bot commented Jun 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Jun 23, 2019
@kevin-brown
Copy link
Member

Fixed in #5508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants