Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bangla (bn) localization #5248

Merged
merged 1 commit into from Sep 7, 2018
Merged

Conversation

eliyas5044
Copy link
Contributor

@eliyas5044 eliyas5044 commented Mar 13, 2018

This pull request includes a

  • Bug fix
  • New feature
  • Translation

Hello, i added new localization of Bangla language (bn).

@pedrofurtado
Copy link
Contributor

@eliyas5044 Please, remove all files of PR from dist. These files are generated automatically in build.

@eliyas5044
Copy link
Contributor Author

@pedrofurtado sorry, i am late, are you talking about to delete dist folder and send pull request again ?

@pedrofurtado
Copy link
Contributor

pedrofurtado commented Sep 7, 2018

@eliyas5044 The only file needed in your PR is the src/js/select2/i18n/bn.js. The other files in dist folder are generated automatically during build process of a new version 👍

I have a doubt: Why did you need to change the Gruntfile?

After this, the PR is ok to be merged 🎉

@eliyas5044 PS: If you know someone that can help us to provide more translations in more locales, please open new PRs. We need the help of community for it 🤝

@eliyas5044
Copy link
Contributor Author

@pedrofurtado done bro :)

@pedrofurtado pedrofurtado merged commit e15046e into select2:develop Sep 7, 2018
@pedrofurtado
Copy link
Contributor

@eliyas5044 Thanks! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants