Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nepali (ne) localization #5295

Merged
merged 2 commits into from May 25, 2018
Merged

Add Nepali (ne) localization #5295

merged 2 commits into from May 25, 2018

Conversation

samundra
Copy link
Contributor

@samundra samundra commented May 18, 2018

This pull request includes a

  • Bug fix
  • New feature
  • Translation

The following changes were made

- Added Nepali (np) localization support

  • Added Nepali (ne) localization support

This Pull Request fixes the #5294 issue.

@kevin-brown
Copy link
Member

Hi @samundra,

Thanks for submitting a translation to Select2! I've reached out to some contacts who are familiar with Nepali to see if they can verify the translations here.

Before we can accept this translation though, we noticed that the incorrect ISO 639 language code appears to be used. The language code for the Nepali language appears to be ne, but these translations were submitted under np (which appears to be unassigned). In order for browsers to automatically pick up the language, and for many systems to indicate the right language, we use the ISO 639 language code to name our translations.

If you can rename the file to ne.js, this will help speed up the process for accepting this pull request. Thank you!

@kevin-brown kevin-brown added this to the 4.0.6 milestone May 19, 2018
@samundra samundra changed the title Add Nepali (np) localization Add Nepali (ne) localization May 21, 2018
@samundra
Copy link
Contributor Author

Hi @kevin-brown

I have renamed the file name. Please, let me know if there is anything I need to address.

Regards,
Samundra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants