Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A disabled control opened by keypress #5440

Closed
Moreplusmas opened this issue Jan 9, 2019 · 3 comments
Closed

A disabled control opened by keypress #5440

Moreplusmas opened this issue Jan 9, 2019 · 3 comments

Comments

@Moreplusmas
Copy link

Hi,

When you disabled a control, you can open it with a keypress event (focus it, and press intro). I solved the issue with this modification:

in "this.on('keypress', function (evt)"

change the last else:

                    if (self.options.options.disabled == false)
                    {
                        if (key === KEYS.ENTER || key === KEYS.SPACE ||
                            (key === KEYS.DOWN && evt.altKey)) {
                            self.open();

                            evt.preventDefault();
                        }
                    }

Thank you for your library, greetings.

@fr0z3nfyr
Copy link

Consider pushing a PR if you think this solves the issue.

@stale
Copy link

stale bot commented Mar 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status: stale label Mar 19, 2019
@stale stale bot closed this as completed Mar 26, 2019
@kevin-brown
Copy link
Member

Duplicate of #4695.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants