Fix bug where dropdowns pointing upwards were incorrectly positioned #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how it used to work pre-4.0.9, where the bound handlers for resizing and positioning the dropdown were bound at the first time that the dropdown was opened. This was changed for the 4.0.9 release as a part of 3f75227 where it was not clear why this late binding was happening, so it was removed to simplify the code. The late binding is necessary because the handlers within results for generating the results, and thus the content within the dropdown, are bound after the handlers for the dropdown are bound. This results in situations where the handlers for positioning the dropdown are bound before the dropdown is updated with content, resulting in the positioning being calculated for the old content and thus being incorrectly placed. By binding the positioning handlers after the dropdow is opened for the first time, we can ensure that the positioning handlers are bound after the result handlers, so we won't have to worry about this issue. The handlers are only bound once because they only need to perform all the calculations a single time. There is no need to keep checking all of the calculated styles more than we need to, so this is guarded by a flag which ensures it is only bound a single time per dropdown. Fixes #5619 Fixes #5620
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a
The following changes were made
If this is related to an existing ticket, include a link to it as well.
Fixes #5619
Fixes #5620