Prevent opening of disabled elements #5751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this pull request contains files in the If you are still interested in making this contribution, feel free to remove the |
Gist: return early from the Select2#open method if the object is disabled. Add helper #isEnabled and #isDisabled methods to Select2 and selector classes. Add test coverage for the original, expected behavior and new preventative behavior.
mcountis
force-pushed
the
prevent_open_disabled
branch
from
95d7d30
to
c56571c
Compare
|
@kevin-brown, please re-review this PR. I have rebased the branch and reverted all |
This was referenced Apr 8, 2020
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return early from
Select2#openif the object is disabled.Addresses #4695.