From 4d9de44d27bdb0d2f9336128bf5feefc720f8f11 Mon Sep 17 00:00:00 2001 From: Micah Brown Date: Tue, 11 Apr 2017 17:07:07 -0500 Subject: [PATCH 1/3] #1513: don't scroll to first selection on select/unselect Resolves issue for multiselects using `closeOnSelect: false` that caused the list of results to scroll to the first selection after each select/unselect --- src/js/select2/results.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/js/select2/results.js b/src/js/select2/results.js index a16b65fd0f..0ef9c100df 100644 --- a/src/js/select2/results.js +++ b/src/js/select2/results.js @@ -112,8 +112,6 @@ define([ // in the dropdown $options.first().trigger('mouseenter'); } - - this.ensureHighlightVisible(); }; Results.prototype.setClasses = function () { From 91114ffc784ae8eb0fb9e1dbe1c4464b477048e4 Mon Sep 17 00:00:00 2001 From: Micah Brown Date: Sat, 22 Apr 2017 17:30:46 -0500 Subject: [PATCH 2/3] Revert "#1513: don't scroll to first selection on select/unselect" This reverts commit 4d9de44d27bdb0d2f9336128bf5feefc720f8f11. --- src/js/select2/results.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/js/select2/results.js b/src/js/select2/results.js index 0ef9c100df..a16b65fd0f 100644 --- a/src/js/select2/results.js +++ b/src/js/select2/results.js @@ -112,6 +112,8 @@ define([ // in the dropdown $options.first().trigger('mouseenter'); } + + this.ensureHighlightVisible(); }; Results.prototype.setClasses = function () { From 818041374d1e3ad5f5e1931be2b41c9fb46428fc Mon Sep 17 00:00:00 2001 From: Micah Brown Date: Sat, 22 Apr 2017 17:31:59 -0500 Subject: [PATCH 3/3] don't focus on first item on every select/unselect --- src/js/select2/results.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/js/select2/results.js b/src/js/select2/results.js index a16b65fd0f..d68d75cdf6 100644 --- a/src/js/select2/results.js +++ b/src/js/select2/results.js @@ -276,7 +276,6 @@ define([ } self.setClasses(); - self.highlightFirstItem(); }); container.on('unselect', function () { @@ -285,7 +284,6 @@ define([ } self.setClasses(); - self.highlightFirstItem(); }); container.on('open', function () {