Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with semantic-release v18 #168

Closed
ismay opened this issue Sep 18, 2021 · 5 comments
Closed

Incompatible with semantic-release v18 #168

ismay opened this issue Sep 18, 2021 · 5 comments

Comments

@ismay
Copy link

ismay commented Sep 18, 2021

In updating to semantic release v18, I noticed that semantic-release/changelog specifies a peerDependency that doesn't allow semantic-release v18: https://github.com/semantic-release/changelog/blob/master/package.json#L64. Is this intentional, or a typo (as in a missing =)?

Currently it's blocking my upgrade to semantic-release v18, see the npm installation error here: https://github.com/ismay/stylelint-no-unsupported-browser-features/pull/191/checks?check_run_id=3639274728#step:4:13

@travi
Copy link
Member

travi commented Sep 18, 2021

Correct. We still have several plugins that still need to be upgraded. For the time being, you can continue to use v17 until all of the plugins that you are using have been updated.

If you would like to help, this is an example of the changes needed for each plugin. PRs are welcome.

@ismay
Copy link
Author

ismay commented Sep 18, 2021

Correct. We still have several plugins that still need to be upgraded. For the time being, you can continue to use v17 until all of the plugins that you are using have been updated.

Ok cool. Yeah I was not sure whether it was an omission or intentional. Thanks for letting me know, I'll stick with v17 for now. Don't have time for contributing atm., just moved, but I will be cheering from the sidelines 😅.

@jdbruijn
Copy link

jdbruijn commented Sep 20, 2021

Wouldn't #167 with an update to the engines just be sufficient to be able to use this with v18, and perhaps just create a separate issue for the comment? I'm not a maintainer, so can't push to the Renovate update branch, but 'd be happy to create a separate PR for the v18 update and updating engines to >=12, would that be a quick solution?

lets add ls-engines to CI to alert us about this in the future

@travi
Copy link
Member

travi commented Sep 20, 2021

this is an example

apologies that i didnt include the link above that i mentioned originally. i've updated my comment to reference the change that we made to one of the other plugins that has already been updated. the update to handle this properly isnt overly complex, we just need to get it handled. if you'd like to help us move this plugin forward more quickly than would happen otherwise, a PR would be welcomed.

@travi
Copy link
Member

travi commented Sep 22, 2021

this is resolved by https://github.com/semantic-release/changelog/releases/tag/v6.0.0

@travi travi closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants