Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GitHub] Deprecation Notice #345

Open
abhisekp opened this issue Jul 10, 2020 · 8 comments
Open

[GitHub] Deprecation Notice #345

abhisekp opened this issue Jul 10, 2020 · 8 comments

Comments

@abhisekp
Copy link

Current behavior

Message from Github after running npx semantic-release setup

Hi @abhisekp,

On July 10th, 2020 at 07:50 (UTC) you or an application you used recently accessed the deprecated Authorizations endpoint on the GitHub API with the useragent semantic-release.

We will remove the Authorizations API endpoint on November 13, 2020. If you accessed the API via password authentication, then we recommend you use the web flow to authenticate. Please check that your app uses the web flow for authentication https://developer.github.com/apps/building-oauth-apps/authorizing-oauth-apps/#web-application-flow

You can learn more about these changes by visiting our developer blog https://developer.github.com/changes/2020-02-14-deprecating-oauth-auth-endpoint/

Thanks,
The GitHub Team

Expected behavior

No emails. Inbox full.

Environment

  • semantic-release version: ^17.1.1
  • CI environment: TravisCI
  • Plugins used:
  • semantic-release configuration:
  • CI logs:
@gr2m gr2m transferred this issue from semantic-release/semantic-release Jul 10, 2020
@gr2m
Copy link
Member

gr2m commented Jul 10, 2020

I think you ran npx semantic-release-cli setup, not npx semantic-release setup.

The CLI really needs some love, but the current maintainers cannot find the time for it.

For this particular case, we wait for the CLI authentication library from @octokit, which will use the OAuth web flow instead of the deprecated authorization APIs

@adrienjoly
Copy link

👋 Just to let you know that I've experienced the same issues after setting up semantic-release on two of my npm packages.

@codebymikey
Copy link

Ran into this issue as well: https://developer.github.com/v3/oauth_authorizations/#create-a-new-authorization

It still posts to https://api.github.com/authorizations and returns the following:

StatusCodeError: 404 - {"message":"Not Found","documentation_url":"https://docs.github.com/rest"}

I believe the octokit module should have the functionality now from browsing around.

@gr2m
Copy link
Member

gr2m commented Nov 16, 2020

sorry :( it really is about time we replace the username/password with an OAuth flow. I might find some time to get this finally going this week

@gr2m
Copy link
Member

gr2m commented Nov 16, 2020

while at it, we should also replace the default travis setup with GitHub actions, because Travis became close to useless lately

@codebymikey
Copy link

I'm literally in the middle of implementing a Github action as my Travis job was essentially in a queue for like 3 hours before being ran, which is pretty bad for such a popular tool.

And it's fine, no huge rush, I just had to reverse engineer what the script was trying to do and applied the environment variables and tokens manually.
If you don't have the time to work on the code, a documentation for the manual process should suffice for new users (as it's pretty straightforward).

@gr2m
Copy link
Member

gr2m commented Nov 16, 2020

this is what my usual release GitHub action looks like:
https://github.com/octokit/core.js/blob/master/.github/workflows/release.yml

You don't need to configure the GITHUB_TOKEN, it's already provided. Unless you have actions triggered by the release event, in which case you need to use a personal access token, because actions don't trigger actions.

@CalmJerome
Copy link

this is what my usual release GitHub action looks like:
https://github.com/octokit/core.js/blob/master/.github/workflows/release.yml

You don't need to configure the GITHUB_TOKEN, it's already provided. Unless you have actions triggered by the release event, in which case you need to use a personal access token, because actions don't trigger actions.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants